Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v8 Bot #621

Merged
merged 22 commits into from
Nov 22, 2023
Merged

feat: v8 Bot #621

merged 22 commits into from
Nov 22, 2023

Conversation

mehah
Copy link
Owner

@mehah mehah commented Nov 6, 2023 •
edited
Loading

kokekanon
kokekanon reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@kokekanon kokekanon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes that are within my range of knowledge

EDIT: I made a mistake; I edited vbot 4.7 instead of vbot 4.8, sorry.
First time I'm doing this on GitHub xd

modules/game_bot/default_configs/vBot_4.7/vBot/extras.lua Outdated
Comment on lines 589 to 602
local voc
if text:lower():find("sorcerer") then
voc = "MS"
elseif text:lower():find("druid") then
voc = "ED"
elseif text:lower():find("knight") then
voc = "EK"
elseif text:lower():find("paladin") then
voc = "RP"
end
local creature = getCreatureByName(name)
if creature then
creature:setText("\n" .. level .. voc .. "\n" .. guild)
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
local voc
if text:lower():find("sorcerer") then
voc = "MS"
elseif text:lower():find("druid") then
voc = "ED"
elseif text:lower():find("knight") then
voc = "EK"
elseif text:lower():find("paladin") then
voc = "RP"
end
local creature = getCreatureByName(name)
if creature then
creature:setText("\n" .. level .. voc .. "\n" .. guild)
end
local voc
if text:lower():find("sorcerer") then
voc = "MS"
elseif text:lower():find("druid") then
voc = "ED"
elseif text:lower():find("knight") then
voc = "EK"
elseif text:lower():find("paladin") then
voc = "RP"
end
if not voc then
return false
end
local creature = getCreatureByName(name)
if creature then
creature:setText("\n" .. level .. voc .. "\n" .. guild)
end

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  if not voc then
    return false
  end

fix this in custom server or old protocol

ERROR: [BOT] [string "/vBot/extras.lua"]:608: attempt to concatenate local 'voc' (a nil value)

modules/game_interface/interface.otmod Outdated
@@ -36,5 +37,7 @@ Module
- game_unjustifiedpoints
- game_shaders
- game_attachedeffects
- client_profiles
- game_bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- game_bot
- game_bot
- game_itemselector

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix click on this
image

modules/game_bot/default_configs/vBot_4.7/vBot/new_healer.otui Outdated
anchors.verticalCenter: prev.verticalCenter

Groups < FlatPanel
size: 150 90
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
size: 150 90
size: 150 100

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

with 90 it is not possible to click on the checkbox

modules/game_bot/default_configs/vBot_4.7/vBot/new_healer.otui Outdated
text: BotServer Members

Vocations < FlatPanel
size: 100 90
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
size: 100 90
size: 100 100

modules/game_bot/default_configs/vBot_4.8/vBot/alarms.lua Outdated
Comment on lines 33 to 36
ui.title.onClick = function(widget)
config.enabled = not config.enabled
widget:setOn(config.enabled)
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ui.title.onClick = function(widget)
config.enabled = not config.enabled
widget:setOn(config.enabled)
end
ui.title.onClick = function(widget)
if not modules.client_options.getOption('enableAudio') and not config.enabled then
warning("Remember to activate sound in options ")
end
config.enabled = not config.enabled
widget:setOn(config.enabled)
end

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By clicking on "alarms" without having "enable audio" option activated.
image

@Nottinghster Nottinghster mentioned this pull request Nov 7, 2023
Closed
5 tasks
@mehah
Copy link
Owner Author

mehah commented Nov 7, 2023

Fixes that are within my range of knowledge

EDIT: I made a mistake; I edited vbot 4.7 instead of vbot 4.8, sorry. First time I'm doing this on GitHub xd

version 4.7 will be removed and wait for me to finish this PR so that the community can open new PR related to the bot.

@otmexa
Copy link

otmexa commented Nov 11, 2023

Fixes that are within my range of knowledge
EDIT: I made a mistake; I edited vbot 4.7 instead of vbot 4.8, sorry. First time I'm doing this on GitHub xd

version 4.7 will be removed and wait for me to finish this PR so that the community can open new PR related to the bot.

How is this implementation going? I'm dying to try it xD

@mehah mehah marked this pull request as ready for review November 17, 2023 15:36
@mehah
Copy link
Owner Author

mehah commented Nov 17, 2023

Fixes that are within my range of knowledge

finished at 85%, now it's up to the community, I'll do the merge soon.

@ericcobblepot
Copy link

Fixes that are within my range of knowledge

finished at 85%, now it's up to the community, I'll do the merge soon.

I think there is an error . the folders do not exist:

  • client_mods
  • game_bot

in the pr

@mehah
Copy link
Owner Author

mehah commented Nov 17, 2023

Fixes that are within my range of knowledge

finished at 85%, now it's up to the community, I'll do the merge soon.

I think there is an error . the folders do not exist:

  • client_mods
  • game_bot

in the pr

sorry, mod has gitignore. fixed

@mehah mehah merged commit 11cecb8 into main Nov 22, 2023
7 of 10 checks passed
@mehah mehah deleted the bot branch November 22, 2023 01:27
@dundermave dundermave mentioned this pull request Mar 2, 2024
Closed
5 tasks
mehah pushed a commit that referenced this pull request Mar 2, 2024
@kokekanon
fix: multiple errors produced in #621 (#712)
64338a5 
* fix: missing font [1]

* fix: Error console [2]

* fix: impossible to click checkbox [3]

* fix: crash (patch solution) [4]

* cleaning: remove incessant print [5]

* Fix: isEnabledWASD was only updated on login

* fix: Panels/widgets not saving positions #703

* fix: No websocket
@Nottinghster Nottinghster mentioned this pull request Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokekanon kokekanon kokekanon left review comments

Assignees
No one assigned
Labels
Area: Datapack Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mehah @otmexa @ericcobblepot @kokekanon @beats-dh @dudantas